Simon A. Boggis wrote:
> Unfortunately, I'm afraid I haven't managed to get a version of ipf to
> build with your orph.patch applied - I've tried to rebuild the one I'm
> currently using - ip_fil4.1.13 (and also 4.1.15 just in case it was
> different), but I get the following error:
>
> $ make freebsd5
> [snip]
> gcc -Wall -Wuninitialized -Wstrict-prototypes -O -Wmissing-prototypes
> -Wpointer-arith -Wno-sign-compare -Wno-traditional -Werror -I. -g
> -I../.. -D_BSD_SOURCE -DUSE_INET6 -DIPFILTER_LOG -DIPFILTER_LOOKUP
> -DIPFILTER_SCAN -DIPFILTER_SYNC -DIPFILTER_CKSUM -c ../../ip_state.c -o
> ip_state_u.o
> ../../ip_state.c: In function `fr_stateunload':
> ../../ip_state.c:304: error: `ISL_UNLOAD' undeclared (first use in this
> function)
> ../../ip_state.c:304: error: (Each undeclared identifier is reported
> only once
> ../../ip_state.c:304: error: for each function it appears in.)
> *** Error code 1
>
> Stop in
> /usr/src/ipfilter/ip_fil4.1.15_with_QM_patches/BSD/FreeBSD-5.4-RELEASE-p22-i386.
> *** Error code 1
>
> I haven't had the chance today to look into the above compile problem
> further.
>
Actually, it seems that reverting the following part of orph.patch makes
it compile cleanly again - so far as I can tell ISL_UNLOAD isn't
defined anywhere.
Is it OK and correct to make this change?
***************
*** 301,307 ****
ipstate_t *is;
while ((is = ips_list) != NULL)
! fr_delstate(is, 0);
/*
* Proxy timeout queues are not cleaned here because although they
--- 301,307 ----
ipstate_t *is;
while ((is = ips_list) != NULL)
! fr_delstate(is, ISL_UNLOAD);
/*
* Proxy timeout queues are not cleaned here because although they
On a similar subject I forgot to mention that the part of the patch to
add the ORPHAN logging to lib/printstate.c doesn't apply cleanly, for
trivial reasons.
Regards
Simon
--
----------------------------------------------------------------------
Dr Simon A. Boggis Senior Network Analyst
Computing Services, Tel. 020 7882 7078
Queen Mary, University of London, London E1 4NS UK.
|