On Wed, Mar 14, 2007 at 08:59:04PM -0600, Matt Day wrote:
> What about the timeout handling in packet_write_wait? Do you really
> want to proceed with the write() and then possibly loop back around
> to the select() call?
Yeah, that's a problem. On platforms that return EAGAIN rather than
EWOULDBLOCK it'll just spin through packet_write_poll() repeatedly.
Probably best to capture the return from select() explicitly test for
a timeout.
--
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
|