OpenSSH
[Top] [All Lists]

Re: 4.6p1 chan_read_failed error

To: openssh-unix-dev@mindrot.org
Subject: Re: 4.6p1 chan_read_failed error
From: Bill Ralph <william.ralph.ctr@navy.mil>
Date: Thu, 05 Apr 2007 13:51:13 -0400
Delivered-to: sp-com-lists@consult.net
Delivered-to: openssh-unix-dev-list1@securepoint.com
Delivered-to: openssh-unix-dev-tmda@mindrot.org
Delivered-to: tmda@mindrot.org
List-archive: <http://lists.mindrot.org/pipermail/openssh-unix-dev>
List-help: <mailto:openssh-unix-dev-request@mindrot.org?subject=help>
List-id: Development of portable OpenSSH <openssh-unix-dev.mindrot.org>
List-post: <mailto:openssh-unix-dev@mindrot.org>
List-subscribe: <http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev>, <mailto:openssh-unix-dev-request@mindrot.org?subject=subscribe>
List-unsubscribe: <http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev>, <mailto:openssh-unix-dev-request@mindrot.org?subject=unsubscribe>
Old-delivered-to: openssh-unix-dev@mindrot.org
Sender: openssh-unix-dev-bounces+openssh-unix-dev-list1=securepoint.com@mindrot.org
User-agent: Thunderbird 1.5.0.10 (X11/20070221)
I just applied the nchan.c patch to openssh-4.6p1 as furnished in the
previous message from Damien Miller:

> Well, it also undoes the fix for bug #52. I think it is safe to simply hush
> the error message:

> Index: nchan.c
> ===================================================================
> CS file: /var/cvs/openssh/nchan.c,v
> retrieving revision 1.56
> diff -u -p -r1.56 nchan.c
> --- nchan.c   5 Aug 2006 02:39:40 -0000       1.56
> +++ nchan.c   4 Apr 2007 03:56:11 -0000
> @@ -135,15 +135,16 @@ chan_rcvd_oclose1(Channel *c)
>  void
>  chan_read_failed(Channel *c)
>   {
> -     debug2("channel %d: read failed", c->self);
> +     debug2("channel %d: read failed, istate %d", c->self, c->istate);
>       switch (c->istate) {
>       case CHAN_INPUT_OPEN:
>               chan_shutdown_read(c);
>               chan_set_istate(c, CHAN_INPUT_WAIT_DRAIN);
>               break;
>       default:
> -             error("channel %d: chan_read_failed for istate %d",
> -                 c->self, c->istate);
> +             if (!c->isatty || !c->detach_close)
> +                     error("channel %d: chan_read_failed for istate %d",
< +                         c->self, c->istate);
>               break;
>       }
>  }

Unfortunately, sshd still produces the message: error: channel 0: 
chan_read_failed for istate 3

-- 

---------------------------------------
 ___ _ _ _   ___      _      _    
| _ |_) | | | _ \__ _| |_ __| |_  
| _ \ | | | |   / _` | | '_ \ ' \ 
|___/_|_|_| |_|_\__,_|_| .__/_||_|
I work for the US Navy.|_| We are not    
responsible for each other's mistakes.
---------------------------------------

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

<Prev in Thread] Current Thread [Next in Thread>