Qmail-LDAP
[Top] [All Lists]

Re: problem qmail-ldap control patch with gcc 4.1

To: qmail-ldap@qmail-ldap.org
Subject: Re: problem qmail-ldap control patch with gcc 4.1
From: Claudio Jeker <jeker@n-r-g.com>
Date: Wed, 22 Nov 2006 16:15:56 +0100
Delivered-to: sp-com-lists@consult.net
Delivered-to: qmail-ldap-list@securepoint.com
Delivered-to: mailing list qmail-ldap@qmail-ldap.org
In-reply-to: <45644CCD.20809@cb-world.de>
Mail-followup-to: Claudio Jeker <jeker@n-r-g.com>, qmail-ldap@qmail-ldap.org
Mailing-list: contact qmail-ldap-help@qmail-ldap.org; run by ezmlm
References: <45644CCD.20809@cb-world.de>
User-agent: Mutt/1.5.12-2006-07-14
On Wed, Nov 22, 2006 at 02:12:45PM +0100, Carsten Böcker wrote:
> Hallo,
> 

 
> make fails with:
> 
> control.c:62: Fehler: Statische Deklaration von »sasl_flags« folgt
> nicht-statischer Deklaration
> control.h:19: Fehler: Vorherige Deklaration von »sasl_flags« war hier
> control.c: In Funktion »control_ldap_search«:
> control.c:408: Warnung: Unverträgliche implizite Deklaration der
> eingebauten Funktion »strndup«
> control.c:463: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne
> Typkonvertierung
> make: *** [control.o] Fehler 1
> 
> google only find this:
> 
> http://www.mail-archive.com/qmail-ldap@qmail-ldap.org/msg05692.html
> 
> change qldap.c
> unsigned        sasl_flags      = LDAP_SASL_AUTOMATIC;
> to
> static unsigned sasl_flags      = LDAP_SASL_AUTOMATIC;
> 
> change control.h
> extern unsigned sasl_flags;
> to
> static unsigned sasl_flags;
> 

Do you actually know what you are doing here?
Changing an extern definition to a static one just like this makes no
sense -- especially in a .h file. Instead you should think about killing
the control.h definition or rename one or the other definition.

-- 
:wq Claudio

<Prev in Thread] Current Thread [Next in Thread>