Qmail
[Top] [All Lists]

Re: qmail Patch Repository

To: Qmail mailing list <qmail@list.cr.yp.to>
Subject: Re: qmail Patch Repository
From: Fabio Busatto <fabio.busatto@sikurezza.org>
Date: Wed, 28 Feb 2007 17:11:40 +0100
Delivered-to: sp-com-lists@consult.net
Delivered-to: gmail-qmail@securepoint.com
Delivered-to: sp.com.list@gmail.com
Delivered-to: mailing list qmail@list.cr.yp.to
In-reply-to: <20070228155340.GA10453@discworld.dyndns.org>
Mailing-list: contact qmail-help@list.cr.yp.to; run by ezmlm
References: <45E59056.50008@cmcflex.com> <20070228151607.GB24361@nachos.phaseit.com> <20070228155340.GA10453@discworld.dyndns.org>
Reply-to: Qmail mailing list <qmail@list.cr.yp.to>
User-agent: Mutt/1.4.2i
On Wed, Feb 28, 2007 at 09:53:40AM -0600, Charles Cazabon wrote:
> Note that scattering tons of preprocessor conditionals through djb's code is
> going to make it *less* readable and significantly increase the chances of
> introducing bugs, possibly including security holes.

This is why I say that the code should not be intrusive.
In my idea, additional features are implemented in their own program functions,
sorrounded by #ifdef, and not more than the function calling should happen in
the original djb code.
I see the bug introduction as a real problem, and this is why I started the
iloveqmail project: to avoid bugs introduced by collating various patches 
together.
Unfortunately the hooks in the original code will overlap, but there is no way 
to
avoid it.

Fabio

<Prev in Thread] Current Thread [Next in Thread>