Qmail
[Top] [All Lists]

Re: qmail Patch Repository

To: Qmail mailing list <qmail@list.cr.yp.to>
Subject: Re: qmail Patch Repository
From: Kyle Wheeler <kyle-qmail@memoryhole.net>
Date: Wed, 28 Feb 2007 09:16:10 -0700
Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys
Delivered-to: sp-com-lists@consult.net
Delivered-to: gmail-qmail@securepoint.com
Delivered-to: sp.com.list@gmail.com
Delivered-to: mailing list qmail@list.cr.yp.to
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=memoryhole.net; b=kNjkD+EBGlUOM4vw3UlWwU0AD6+r+WGFDyNRrxGOofSJkXgNze5u6p4zv9NpEKkvf9AamzFPKCOOTyK2FTh2bwC8QO339YstWC513dtS3xUMSQwPZgTnutmYH2/mRGWViV1De0Orf7JlmDL6jC+xG1iGJsQXdJt8OG4b+nEwcRI= ;
Domainkey-status: good
In-reply-to: <20070228155340.GA10453@discworld.dyndns.org>
Mail-followup-to: Qmail mailing list <qmail@list.cr.yp.to>
Mailing-list: contact qmail-help@list.cr.yp.to; run by ezmlm
References: <45E59056.50008@cmcflex.com> <20070228151607.GB24361@nachos.phaseit.com> <20070228155340.GA10453@discworld.dyndns.org>
User-agent: Mutt/1.5.14 (2007-02-27)
On Wednesday, February 28 at 09:53 AM, quoth Charles Cazabon:
Fabio Busatto <fabio.busatto@sikurezza.org> wrote:
On Wed, Feb 28, 2007 at 07:23:18AM -0700, mlist wrote:
Sounds like a great idea to me. It would help if the patches were categorized . . . I guess kind of like how squirrelmail has their plugins section organized? http://www.squirrelmail.org/plugins.php

Yes, this is reasonable. The idea is to create a system like the kernel, using a .config file and a pool of #ifdef preprocessor directives.

Note that scattering tons of preprocessor conditionals through djb's code is going to make it *less* readable and significantly increase the chances of introducing bugs, possibly including security holes.

Fair warning.

I agree. I don't want preprocessor conditionals in there either. Part of what I value about qmail is the ability to read the source if I need to figure out how on earth something strange happened (i.e. debugging patches). I strongly favor a patch-o-matic style operation where patches can be selectively applied.

~Kyle
--
I contend that we are both atheists. I just believe in one fewer god than you do. When you understand why you dismiss all the other possible gods, you will understand why I dismiss yours.
                                         -- Sir Stephen Henry Roberts

Attachment: pgp4wfhpbFLoi.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>