Qmail
[Top] [All Lists]

Re: Qmail TLS - No Received encrypted header

To: qmail@list.cr.yp.to
Subject: Re: Qmail TLS - No Received encrypted header
From: Kyle Wheeler <kyle-qmail@memoryhole.net>
Date: Thu, 9 Aug 2007 12:37:09 -0600
Comment: DomainKeys? See http://domainkeys.sourceforge.net/
Delivered-to: sp-com-lists@consult.net
Delivered-to: gmail-qmail@securepoint.com
Delivered-to: sp.com.list@gmail.com
Delivered-to: mailing list qmail@list.cr.yp.to
Dkim-signature: v=0.5; a=rsa-sha1; c=relaxed; d=memoryhole.net; h=received:received:date:from:to:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; q=dns/txt; s=default; bh=IqJBOx3CPAKqS/blj8H0suFLt/8=; b=ZsP6mr7kd+w//VvAQDyLy7tCFZyn5gDYQEkVfZwfijs8xmvoYYDbbC7GdkY6nVCc1o39KheYEuhwnE9MIsyD5CXq36X8h8e4o1me69HzwzVbCEqKzcpZp4hyU5tdNLoHpe6nkI2bYC1OCkW9zKVpzsQVoHz7vQBshW9z4DvDkrg=
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=memoryhole.net; b=UIGs4H5bk22DSTEgWxYXWI2BhtA6liVW5elWtdH/jbdk5zwb5/liqfYUUBCOnrx3/7C3EhUmr6tjFWLfREV6w5ELsq4UcfAZ+Po37AR7NaTOfGaYBg6f4+tZFO5t/Dxwolg8nuaQbcMwZJUpDS54lJ7CTRj+7+LBuOMnTDDMFKk=; h=Received:Received:Date:From:To:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent;
Domainkey-status: good
In-reply-to: <636837.39174.qm@web57003.mail.re3.yahoo.com>
Mail-followup-to: qmail@list.cr.yp.to
Mailing-list: contact qmail-help@list.cr.yp.to; run by ezmlm
References: <636837.39174.qm@web57003.mail.re3.yahoo.com>
User-agent: Mutt/1.5.16 (2007-07-09)
On Thursday, August  9 at 09:41 AM, quoth Unga:
I don't get a "Received [..] with (DHE-RSA-AES256-SHA
encrypted) SMTP;") header in mails I send. I tried
with Thunderbird ver. 1.5.0.7. What I get is:
Received: ...with ESMTPA.

It's because of a bit of laziness on the part of the person merging the two patches. The AUTH patch sets the protocol string to be "ESMTPA", and the TLS patch sets the protocol string to be "(DHE-RSA-AES256-SHA encrypted) SMTP", and they overwrite each other. Whichever one happens last wins; so if you encrypt first and then auth, all you'll see is that your mail was sent authenticated.

Look in the code, in smtp_auth(), for where it says:

    protocol = "ESMTPA";

and replace it with:

    if (smtps && ssl) {
        if (!stralloc_copys(&proto, "ESMTPSA (")
          || !stralloc_cats(&proto, SSL_get_cipher(ssl))
|| !stralloc_cats(&proto, " encrypted, authenticated)")) die_nomem();
        if (!stralloc_0(&proto)) die_nomem();
        protocol = proto.s;
    } else {
        protocol = "ESMTPA";
    }

...and you'll have to move the definition of the proto variable higher up in the file so that smtp_auth() can have access to it.

Or you can complain to the guy you got the patch from! :)

~Kyle
--
Power always thinks it has a great soul and vast views beyond the comprehension of the weak; and that it is doing God's service when it is violating all his laws.
                                                         -- John Adams

Attachment: pgpxG6uIXuRb9.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>