djbdns
[Top] [All Lists]

Re: djbdns-1.05-epoll + speedup patch

To: djbdns Mailing List <dns@list.cr.yp.to>
Subject: Re: djbdns-1.05-epoll + speedup patch
From: "Matthew R. Dempsky" <mrd@alkemio.org>
Date: Mon, 5 Mar 2007 10:13:16 -0600
Delivered-to: sp-com-lists@consult.net
Delivered-to: gmail-djbdns@securepoint.com
Delivered-to: sp.com.list@gmail.com
Delivered-to: mailing list dns@list.cr.yp.to
In-reply-to: <20070305144746.rrksiglhg3ljhvjp@m.safari.iki.fi>
Mail-followup-to: djbdns Mailing List <dns@list.cr.yp.to>
Mailing-list: contact dns-help@list.cr.yp.to; run by ezmlm
References: <20070116171333.GA5674@m.safari.iki.fi> <20070222122129.GE3982@m.safari.iki.fi> <20070222162522.GG3982@m.safari.iki.fi> <20070304161657.qrytvzoi37inmj45@m.safari.iki.fi> <20070305142437.GA27256@odin.dempsky.org> <20070305144746.rrksiglhg3ljhvjp@m.safari.iki.fi>
On Mon, Mar 05, 2007 at 04:47:46PM +0200, Sami Farin wrote:
> Not that it matters much, but version 20070305T031624Z
> already compares >= 0.  It also does one useless loop
> if n == 1 before for-loop unless I check for it.  But dns_sortip
> is called by dnscache only with n == 64 (16).

I'm refering to the fact that the former code uses the Knuth shuffle
algorithm to generate a uniform distribution over all possible
permutations.  The new code does not.

See http://en.wikipedia.org/wiki/Knuth_shuffle#Poorly_implemented_Knuth_shuffles

<Prev in Thread] Current Thread [Next in Thread>